3 Commits

Author	SHA1	Message	Date
shuki	065f83d691	Fix AdminBin: add shebang and __PACKAGE__->run() ... cPanel's adminbin framework requires the module to be directly executable with a shebang line, and Script::Call modules need __PACKAGE__->run() to bootstrap. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>	2026-03-05 01:57:56 +02:00
shuki	3b6d9ea88f	Fix AdminBin compilation: declare $in/$out before open3 ... Variables declared with 'my' inside open3() were scoped to that call, causing 'Global symbol requires explicit package name' errors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>	2026-03-05 01:52:19 +02:00
shuki	1f68ea1058	Security hardening, static analysis fixes, and expanded test coverage ... - Fix CRITICAL: safe config parser replacing shell source, sshpass -e, CSRF with /dev/urandom, symlink-safe file I/O - Fix HIGH: input validation for timestamps/accounts, path traversal prevention in Runner.pm, AJAX CSRF on all endpoints - Fix MEDIUM: umask 077, chmod 700 on config dirs, Config.pm TOCTOU lock, rsync exit code capture bug, RSYNC_EXTRA_OPTS character validation - ShellCheck: fix word-splitting in notify.sh, safe rm in pkgacct.sh, suppress cross-file SC2034 false positives - Perl::Critic: return undef→bare return, return (sort), unpack @_, explicit return on void subs, rename Config::write→save - Remove dead code: enforce_retention_all(), rsync_dry_run() - Add require_cmd checks for rsync/ssh/hostname/gzip at startup - Escape $hint/$tip in CGI helper functions for defense-in-depth - Expand tests from 17→40: validate_timestamp, validate_account_name, _safe_source_config (including malicious input), numeric validation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>	2026-03-04 23:57:26 +02:00