shukivaknin/gniza4linux
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use SIGKILL and os.getpgid for reliable job killing

Browse Source 
SIGTERM was being ignored by child processes. Use SIGKILL via the
actual process group ID, with proc.kill() as fallback.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
shuki
2026-03-06 18:16:09 +02:00
parent 5e21d1b20a
commit 6a0389f437
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tui/jobs.py
View File

@@ -82,8 +82,12 @@ class JobManager:
@staticmethod @staticmethod
def _kill_process_group(proc: asyncio.subprocess.Process) -> None: def _kill_process_group(proc: asyncio.subprocess.Process) -> None:
try: try:
os.killpg(proc.pid, signal.SIGTERM) pgid = os.getpgid(proc.pid)
except (ProcessLookupError, PermissionError): os.killpg(pgid, signal.SIGKILL)
except (ProcessLookupError, PermissionError, OSError):
try:
proc.kill()
except (ProcessLookupError, OSError):
pass pass
def kill_job(self, job_id: str) -> bool: def kill_job(self, job_id: str) -> bool: